Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A/B test for AI Site Generation #532

Merged
merged 10 commits into from
Apr 8, 2024
Merged

A/B test for AI Site Generation #532

merged 10 commits into from
Apr 8, 2024

Conversation

officiallygod
Copy link
Member

@officiallygod officiallygod commented Apr 3, 2024 •
edited
Loading

Proposed changes

Shows a Random different Fork Page to the user for A/B Testing

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

New Look

Screenshot 2024-04-05 at 12 12 35 PM Screenshot 2024-04-05 at 12 13 51 PM Screenshot 2024-04-05 at 1 49 26 PM Screenshot 2024-04-05 at 1 50 12 PM

Note: Please check the earlier events if they are working as expected.

@officiallygod officiallygod added the WIP PR is a Work in Progress and not ready for review. label Apr 3, 2024
@officiallygod officiallygod self-assigned this Apr 3, 2024
@officiallygod officiallygod added Code Review The PR is in Code Review and removed WIP PR is a Work in Progress and not ready for review. labels Apr 5, 2024
arunshenoy99
arunshenoy99 reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@officiallygod Quick question: How does this work if we want to do A/B testing with other steps? Is it a good idea to use some kind of state handler that determines what needs to be rendered that we reuse?

@officiallygod
Copy link
Member Author

@officiallygod Quick question: How does this work if we want to do A/B testing with other steps? Is it a good idea to use some kind of state handler that determines what needs to be rendered that we reuse?

The requirements are very specific to a section of the page and doing that would make us send all that data to the parent and again have a lot of dup code as we would then need to build 4 completely independent components which do the same thing (StartOptions in this case).

@officiallygod
Copy link
Member Author

Onboarding Data: newfold-labs/wp-module-onboarding-data#68

@arunshenoy99 arunshenoy99 added Ready to merge The Code Review and QA is done and it can be merged. and removed Code Review The PR is in Code Review labels Apr 8, 2024
@arunshenoy99 arunshenoy99 merged commit 447d2f9 into trunk Apr 8, 2024
1 of 4 checks passed
@arunshenoy99 arunshenoy99 deleted the feature/ab-test-for-AI-Sitgeneration branch April 8, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunshenoy99 arunshenoy99 arunshenoy99 approved these changes

Assignees

@officiallygod officiallygod

Labels
Ready to merge The Code Review and QA is done and it can be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@officiallygod @arunshenoy99